Fix recently broken jq reference to "$p" value in omarchy-launch-or-focus#4766
Merged
dhh merged 1 commit intobasecamp:devfrom Feb 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 27, 2026
dhh
added a commit
that referenced
this pull request
Feb 27, 2026
Fix recently broken jq reference to "$p" value in omarchy-launch-or-focus
Member
|
Pushed as a hotfix to master. Thanks for catching! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 7514ae7 that went out with the 3.4.0 release buried in the changes to Use consistent bash5 style for conditionals and quoting we can see that commit accidentally stripped the
$from first$preference when testing the class name. This can be easily reproduced:With this fix, it works: