Skip to content

Fix recently broken jq reference to "$p" value in omarchy-launch-or-focus#4766

Merged
dhh merged 1 commit intobasecamp:devfrom
garethson:fix-omarchy-launch-or-focus
Feb 27, 2026
Merged

Fix recently broken jq reference to "$p" value in omarchy-launch-or-focus#4766
dhh merged 1 commit intobasecamp:devfrom
garethson:fix-omarchy-launch-or-focus

Conversation

@garethson
Copy link
Contributor

In 7514ae7 that went out with the 3.4.0 release buried in the changes to Use consistent bash5 style for conditionals and quoting we can see that commit accidentally stripped the $ from first $p reference when testing the class name. This can be easily reproduced:

~/code/tmp ❯ omarchy-launch-or-focus code 
jq: error: p/0 is not defined at <top-level>, line 1, column 33:
    .[]|select((.class|test("\\b" + p + "\\b";"i")) or (.title|test("\\b" + $p + "\\b";"i")))|.address```

With this fix, it works:

[master] ~/code/devnotes ❯ omarchy-launch-or-focus code
ok

Copilot AI review requested due to automatic review settings February 27, 2026 05:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dhh dhh merged commit f88bd13 into basecamp:dev Feb 27, 2026
dhh added a commit that referenced this pull request Feb 27, 2026
Fix recently broken jq reference to "$p" value in omarchy-launch-or-focus
@dhh
Copy link
Member

dhh commented Feb 27, 2026

Pushed as a hotfix to master. Thanks for catching!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants