Merged
Conversation
Contributor
|
@rdsharma26, could you take a look at this PR, please? |
Contributor
|
Thanks @akalotkin for the PR. Can you add the copyright header to the new file, in order to unblock the build? |
Contributor
Author
|
@rdsharma26 The copyright has been added. |
Contributor
|
Thank you. The changes look good and we are internally reviewing as well. We will get back to you by tomorrow. |
mentekid
approved these changes
Apr 11, 2024
Contributor
mentekid
left a comment
mentekid
left a comment
There was a problem hiding this comment.
Thanks for the contribution - I am merging your change.
In the future, it would be interesting to implement this for any type of aggregation, not just sum. We could support aggregations like average to make this more generic.
Contributor
|
Opened this to track |
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Added RatioOfSums analyzer and tests * Unit test for divide by zero and code cleanup. * More detailed Scaladoc * Fixed docs to include Double.NegativeInfinity * Add copyright to new file
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Added RatioOfSums analyzer and tests * Unit test for divide by zero and code cleanup. * More detailed Scaladoc * Fixed docs to include Double.NegativeInfinity * Add copyright to new file
rdsharma26
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Added RatioOfSums analyzer and tests * Unit test for divide by zero and code cleanup. * More detailed Scaladoc * Fixed docs to include Double.NegativeInfinity * Add copyright to new file
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Added RatioOfSums analyzer and tests * Unit test for divide by zero and code cleanup. * More detailed Scaladoc * Fixed docs to include Double.NegativeInfinity * Add copyright to new file
rdsharma26
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Added RatioOfSums analyzer and tests * Unit test for divide by zero and code cleanup. * More detailed Scaladoc * Fixed docs to include Double.NegativeInfinity * Add copyright to new file
shriyavanvari
pushed a commit
that referenced
this pull request
May 2, 2024
* Added RatioOfSums analyzer and tests * Unit test for divide by zero and code cleanup. * More detailed Scaladoc * Fixed docs to include Double.NegativeInfinity * Add copyright to new file
shriyavanvari
pushed a commit
that referenced
this pull request
May 2, 2024
* Added RatioOfSums analyzer and tests * Unit test for divide by zero and code cleanup. * More detailed Scaladoc * Fixed docs to include Double.NegativeInfinity * Add copyright to new file
arsenalgunnershubert777
pushed a commit
to arsenalgunnershubert777/deequ
that referenced
this pull request
Nov 8, 2024
* Added RatioOfSums analyzer and tests * Unit test for divide by zero and code cleanup. * More detailed Scaladoc * Fixed docs to include Double.NegativeInfinity * Add copyright to new file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR creates a new analyzer called RatioOfSums. It aggregates and sums 2 separate columns, then divides them.
For example, imagine a baseball dataset that contains hits and total at-bats, with a row for every player in every game. If a player's batting average (total hits/total at-bats) changes by more than 0.2 in one week, an error or warning could be given. Another example is a % of total calculation in a table that has many rows with facts val1, val2, val3, total, and we want to ensure that val1's percent of the total doesn't change more than X in a given time period.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.