[Databases] Fix query behavior + general cleanup#2198
Open
drkameleon wants to merge 2 commits intomasterfrom
Open
[Databases] Fix query behavior + general cleanup#2198drkameleon wants to merge 2 commits intomasterfrom
query behavior + general cleanup#2198drkameleon wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now, our database module suffers from various issues:
execManySqliteDbhas no ROLLBACK on failureselectto figure out whether a query will return rows or not - this is totally fragilequerypushes nothing on non-SELECT queries.idand the result itself can both be push to the stackexecManySqliteDbalways returnsEmptyQueryResult.mysqlis obsolete/unusedopendoesn't handle errors properlyclosedoesn't catch errors properly eitherType of change