sec,stat: fix stat64 struct definition#125
Merged
Snaipe merged 2 commits intoaristanetworks:mainfrom Jan 22, 2026
Merged
Conversation
This makes it obvious that these types and functions are specifically tailor-made for 32-bit architectures, which typically have a different alignment than 64-bit.
This change fixes the struct definition of stat64 to actually match the i686 system call interface. Among other things: * It has a broken _ino (__st_ino) field near the beginning, which must be partially filled with the bottom 32-bits of the inode, and a second, non-broken ino (st_ino) field at the end, which is the real inode. * It is packed and 4-byte aligned, so that when bst is compiled on a 64-bit architecture, the struct remains compatible * The timestamp fields are still 32-bit. Go figure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the definition of the stat64 struct type.
Its definition was based on glibc rather than the actual kernel header, and it wasn't 4-byte-aligned, which meant that it was significantly larger than the allocated buffer in the caller process, and presumably smashed the stack and/or heap depending on where that buffer lived.