seccomp: skip supervisor for nested calls#119
Merged
Snaipe merged 1 commit intoaristanetworks:mainfrom Oct 29, 2025
Merged
Conversation
The old code returned a fake epoll fd as the supervisor fd to avoid refactoring the fd passing code, but it was just a hack. This commit does things properly by allowing send_fd to accept -1 to signify "send no file descriptor". A matching recv_fd will in turn return -1. This allows us to return -1 when the supervisor already exists somewhere up the chain and skip the nested supervisor loop if that's the case.
yabberyabber
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code returned a fake epoll fd as the supervisor fd to avoid refactoring the fd passing code, but it was just a hack.
This commit does things properly by allowing send_fd to accept -1 to signify "send no file descriptor". A matching recv_fd will in turn return -1.
This allows us to return -1 when the supervisor already exists somewhere up the chain and skip the nested supervisor loop if that's the case.