Draft
Conversation
tombruijn
force-pushed
the
jruby10-compatibility
branch
from
3d4f9b6 to
e9e806d
Compare
tombruijn
force-pushed
the
jruby10-compatibility
branch
from
e9e806d to
1144661
Compare
Add JRuby 10 to the build matrix.
The patchlevel of the Ruby version is included in JRuby and MRI after updating the JRuby versions. Update the assertion to match.
For JRuby 10 with Rails, these files needs to be loaded.
tombruijn
force-pushed
the
jruby10-compatibility
branch
from
1144661 to
63e97ce
Compare
Member
Author
|
The way to reproduce this locally for me was to run the following spec files JRuby: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #1406
Closes #1405
Add JRuby 10 to the CI matrix
Add JRuby 10 to the build matrix.
Fix diagnose test for JRuby
The patchlevel of the Ruby version is included in JRuby and MRI after updating the JRuby versions. Update the assertion to match.
Fix ActionCable test helper loading on JRuby
For JRuby 10 with Rails, these files needs to be loaded.