wip: Strongly Typed Path strings and therefore fix all mismatch/normalisation issues on windows#18692
Draft
Hona wants to merge 44 commits intoanomalyco:devfrom
Draft
wip: Strongly Typed Path strings and therefore fix all mismatch/normalisation issues on windows#18692Hona wants to merge 44 commits intoanomalyco:devfrom
Hona wants to merge 44 commits intoanomalyco:devfrom
Conversation
…rywhere # Conflicts: # packages/opencode/src/file/index.ts # packages/opencode/src/file/watcher.ts # packages/opencode/src/lsp/server.ts # packages/opencode/src/permission/index.ts # packages/opencode/src/permission/service.ts # packages/opencode/src/skill/skill.ts
Hona
changed the title
atharvau
reviewed
Mar 23, 2026
atharvau
left a comment
atharvau
left a comment
There was a problem hiding this comment.
Code Review for PR #18692: WIP Path Handling
⚠️ Work in Progress - Early Feedback
This PR appears to be a comprehensive rewrite of path handling for Windows compatibility. Since it's marked as WIP with no description and a very large diff (20k+ lines), here's some early feedback:
📋 Recommendations for Development
-
Add PR Description: Please add a detailed description explaining:
- What problems this solves
- High-level approach taken
- Breaking changes introduced
- Testing strategy
-
Consider Breaking Into Smaller PRs: This could potentially be split into:
- Type definitions and interfaces
- Core path utilities
- Migration of existing usage
- Tests and validation
-
Add Tests: Ensure comprehensive test coverage for:
- Windows-specific path scenarios
- Cross-platform compatibility
- Migration paths for existing data
-
Review vs PR #18709: This seems related to the other path handling PR (#18709). Consider how they relate and if they can be consolidated.
🔍 Ready for Review When:
- PR description added with clear goals
- Tests included for path handling logic
- Potential breaking changes documented
- WIP status removed
Happy to provide detailed technical review once the PR is ready for review!
Status: AWAITING AUTHOR (WIP)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.