fix(read): skip external directory prompt for global AGENTS.md#13753
Open
scarf005 wants to merge 2 commits intoanomalyco:devfrom
Open
fix(read): skip external directory prompt for global AGENTS.md#13753scarf005 wants to merge 2 commits intoanomalyco:devfrom
scarf005 wants to merge 2 commits intoanomalyco:devfrom
Conversation
scarf005
force-pushed
the
fix/13751/config-dir-permission-prompt
branch
from
b8dfa36 to
4b2e20d
Compare
scarf005
force-pushed
the
fix/13751/config-dir-permission-prompt
branch
from
4b2e20d to
0606c89
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13751 by skipping
external_directorypermission prompts when the target file is already part ofInstructionPrompt.systemPaths()(for example~/.config/opencode/AGENTS.md).This keeps regular external directory protection for unrelated paths, but avoids interrupting instruction-loading flows for OpenCode-owned/global instruction files that are already trusted as system instructions.
I also added a regression test in
test/tool/read.test.tsto verify that reading globalAGENTS.mddoes not requestexternal_directorypermission.How did you verify your code works?
bun test test/tool/read.test.ts -t "global AGENTS.md"(frompackages/opencode)git push(bun turbo typecheck).