Merged
Conversation
0905798 to
7383ca5
Compare
Author
|
@ai, @anandthakker Requested a review, just to make sure noone disagrees with the decision to handle the problem in doiuse. I know you're both busy, so I'm not expecting any replies, but I just wanted to keep you both informed and give you the opportunity to object if you disagree. If there aren't any objections I'll try to merge and release a new version this week. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently doiuse will throw an error for unrecognised node types. Users using LESS with import statements are running into problems with this because the less parser introduced a new node type for import statements:
By ignoring unrecognised node types doiuse will only warn about known syntax, and we can leave the check for syntax validity to other tools.
See discussion in RJWadley/stylelint-no-unsupported-browser-features#36 and stylelint/stylelint#2904.
As users might depend on their build breaking because of this I'm intending to publish this as a breaking change (i.e. new major version).