Avoid fetching loop time on each request unless logging is enabled

[bdraco]

We would call loop.time() and than throw it away most of the time because logging was not enabled by default. This makes a syscall (or VDSO on more performant systems) and can be upwards of 8% of the request overhead on some ARM SBCs because of ARM errata that prevents VDSO from working (Cortex-A*3 and others)

Note that this will not show a performance difference with codspeed since it excludes syscalls. It will need to be checked manually.

Looks to be ~2% speed up of request handling time on systems that support VDSO, and ~8% speed up on systems that don't
We still have one for the keep alive that we likely can't get rid of

[codspeed-hq]

CodSpeed Performance Report

Merging #10713 will not alter performance

_{Comparing avoid_loop_time_fetch (ef3aa38) with master (75bbc03)}

Summary

✅ 56 untouched benchmarks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (75bbc03) to head (ef3aa38).
Report is 537 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #10713   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         125      125           
  Lines       37733    37751   +18     
  Branches     2082     2081    -1     
=======================================
+ Hits        37251    37271   +20     
+ Misses        334      333    -1     
+ Partials      148      147    -1     

Flag	Coverage Δ
CI-GHA	98.60% <100.00%> (+<0.01%)	⬆️
OS-Linux	98.27% <100.00%> (+<0.01%)	⬆️
OS-Windows	96.22% <100.00%> (+<0.01%)	⬆️
OS-macOS	97.39% <100.00%> (+<0.01%)	⬆️
Py-3.10.11	97.30% <100.00%> (+<0.01%)	⬆️
Py-3.10.17	97.85% <100.00%> (+0.01%)	⬆️
Py-3.11.12	97.93% <100.00%> (+0.05%)	⬆️
Py-3.11.9	97.38% <100.00%> (+<0.01%)	⬆️
Py-3.12.10	98.03% <100.00%> (+<0.01%)	⬆️
Py-3.12.9	97.50% <100.00%> (+<0.01%)	⬆️
Py-3.13.2	97.48% <100.00%> (+<0.01%)	⬆️
Py-3.13.3	98.04% <100.00%> (+<0.01%)	⬆️
Py-3.9.13	97.17% <100.00%> (+<0.01%)	⬆️
Py-3.9.22	97.70% <100.00%> (+<0.01%)	⬆️
Py-pypy7.3.16	81.81% <85.00%> (-15.48%)	⬇️
VM-macos	97.39% <100.00%> (+<0.01%)	⬆️
VM-ubuntu	98.27% <100.00%> (+<0.01%)	⬆️
VM-windows	96.22% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

I still need to write another test for this one. I keep getting pulled on to other tasks though

[Dreamsorcerer]

I still need to write another test for this one. I keep getting pulled on to other tasks though

I was looking for a missing partial shown on the previous commit, but it's gone after merging master, so all good.

[patchback]

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 8d74e26 on top of patchback/backports/3.11/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713

Backporting merged PR #10713 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.11/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713 upstream/3.11

4. Now, cherry-pick PR Avoid fetching loop time on each request unless logging is enabled #10713 contents into that branch:

   $ git cherry-pick -x 8d74e26c70adeabda54c963d4744672c1874cb06

   If it'll yell at you with something like fatal: Commit 8d74e26c70adeabda54c963d4744672c1874cb06 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 8d74e26c70adeabda54c963d4744672c1874cb06

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Avoid fetching loop time on each request unless logging is enabled #10713 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.11/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 8d74e26 on top of patchback/backports/3.12/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713

Backporting merged PR #10713 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.12/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713 upstream/3.12

4. Now, cherry-pick PR Avoid fetching loop time on each request unless logging is enabled #10713 contents into that branch:

   $ git cherry-pick -x 8d74e26c70adeabda54c963d4744672c1874cb06

   If it'll yell at you with something like fatal: Commit 8d74e26c70adeabda54c963d4744672c1874cb06 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 8d74e26c70adeabda54c963d4744672c1874cb06

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Avoid fetching loop time on each request unless logging is enabled #10713 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.12/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.