chore: add OwnerReference to created resources#3902
Closed
foyerunix wants to merge 1 commit intoactions:masterfrom
Closed
chore: add OwnerReference to created resources#3902foyerunix wants to merge 1 commit intoactions:masterfrom
foyerunix wants to merge 1 commit intoactions:masterfrom
Conversation
Contributor
|
duplicates: #3575 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is basically an alternative implementation of #3575 taking into account the points raised by @nikola-jokic.
It improves upon it by:
APIVersionandKindPlease note that I had to move the namespace where we create the
autoscalinglistenersfrom the namespace where we run the controller to the namespace where we run the runners. Without this change, theautoscalinglistenerscannot be owned by their respectiveAutoscalingRunnerSet. If this is incorrect, please advise on the alternative approach so I can rework my PR accordingly.It is running in my environment with no issues so far.
Best Regards.