Referential stability for observer result objects#10265
Referential stability for observer result objects#10265zeorin wants to merge 2 commits intoTanStack:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.Add a configuration file to your project to customize how CodeRabbit runs oxc. |
|
themavik
left a comment
There was a problem hiding this comment.
QueryObserver.trackResult / MutationObserver trackResult caching with WeakMap + shallowEqualObjects on #updateResult should cut a lot of proxy churn. nit: render-optimizations.md now says hook return objects are stable unless RQ triggers a re-render — worth one clause that option/key changes still produce new result objects when underlying data moves, so readers do not read stable as frozen forever.
🎯 Changes
✅ Checklist
pnpm run test:pr. (Didn't work for me, butnpx nx run @tanstack/react-query:test:libpasses).🚀 Release Impact