Sync | Make buttons and links clickable without affecting page speed performance and SEO#387
Open
sc-krishanthakumara wants to merge 7 commits intoSitecore:mainfrom
Open
Conversation
…ef and fix build issues
|
@sc-krishanthakumara is attempting to deploy a commit to the Sitecore JSS Team on Vercel. A member of the Team first needs to authorize it. |
sc-shakyawijerathne
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Links and buttons across the Sync (click-click-launch) site were non-functional due to placeholder
url="#"values in SYNC branch item serialization files. These#values were being normalised tohttp://#by the Sitecore Content SDK at render time, causing clicks to navigate to a blank page. A previous workaround in the component layer made links unclickable entirely, which was also incorrect.This PR resolves the issue cleanly across three areas:
1. SYNC YML data — replace all
#placeholder URLs with meaningful paths/Speakers/Speakers/Heritage-30and/Speakers/Heritage-50respectively/click-click-launchSYNC branch items2. Component layer — remove placeholder href workaround logic
isPlaceholderHrefhelper andHeroLinkwrapper fromHeroST.tsx,HeaderST.tsx,MultiPromo.tsx,AccordionBlock.tsx, andMiniCart.tsxContentSdkLink, consistent with the original backup-chathumika branch approach<button>since its action is toggling a panel, not navigation3. Accessibility — unique
aria-labelon repeated "Learn more" linksaria-labelderived from its section context (e.g.aria-label="Monarch II details",aria-label="Damian Turner artist series")The fix avoids any client-side URL manipulation, extra re-renders, or JavaScript-based navigation overrides that could affect Page Speed Insights scores. Links are standard anchor elements pointing to real paths with no PSI or Core Web Vitals impact.