build: Lock GitHub runners' OS#1765
Merged
jesse-c merged 5 commits intoSeldonIO:masterfrom May 30, 2024
jesse-c:lock-github-runners
Merged
build: Lock GitHub runners' OS#1765jesse-c merged 5 commits intoSeldonIO:masterfrom jesse-c:lock-github-runners
jesse-c merged 5 commits intoSeldonIO:masterfrom
jesse-c:lock-github-runners
Conversation
sakoush
approved these changes
May 29, 2024
Contributor
sakoush
left a comment
There was a problem hiding this comment.
Thanks for sorting it out! I left comments, once they are resolved then PR is good to go.
Contributor
Author
|
Going to merge in, based on the latest results [1]. It looks like the new Docker setup still needs some work, based on the error message [2]. [1] https://github.com/SeldonIO/MLServer/actions/runs/9302553271?pr=1765 |
This was motivated by our macOS jobs failing [2] because colima is missing. It looks like this is because the latest versions of the macOS runner no longer have colima installed by default [1]. colima is now explicitly installed. [1] actions/runner-images#6216 [2] `/Users/runner/work/_temp/f19ffbff-27a9-4fc7-80b6-97791d2de141.sh: line 9: colima: command not found`
The > 0.6.0 releases actually fix the issue we have linked [1][2][3]. [1] abiosoft/colima#577 [2] https://github.com/jesse-c/MLServer/blob/c3acd60995a72141027eff506e4fd330fe824179/hack/install-docker-macos.sh#L18-L20 [3] > Switch to new user-v2 network. Fixes abiosoft/colima#648, abiosoft/colima#603, abiosoft/colima#577, abiosoft/colima#779, abiosoft/colima#137, abiosoft/colima#740.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was motivated by our macOS jobs failing [2] because colima is missing. It looks like this is because the latest versions of the macOS runner no longer have colima installed by default [1].
colima is now explicitly installed. The incompatible
--network-driverargument for this version of colima has been removed as well.Since macOS isn't used for PRs, I had temporarily disabled that check to see the actions run. For seeing the results, you'll need to look at previous runs for this PR, before I re-enabled the PR check.
I think the way that
poetry installis done in the workflow description and in the Tox environments seems wrong/duplicative. It ends up taking long as it's duplicated and you can see a mix of upgrades/downgrades done, that could be avoided.[1] actions/runner-images#6216
[2]
/Users/runner/work/_temp/f19ffbff-27a9-4fc7-80b6-97791d2de141.sh: line 9: colima: command not found