fix(pandas): Use Pydantic v2 compatible type#1760
Merged
jesse-c merged 1 commit intoSeldonIO:masterfrom May 15, 2024
jesse-c:dataplane-use-pydantic-v2-type
Merged
fix(pandas): Use Pydantic v2 compatible type#1760jesse-c merged 1 commit intoSeldonIO:masterfrom jesse-c:dataplane-use-pydantic-v2-type
jesse-c merged 1 commit intoSeldonIO:masterfrom
jesse-c:dataplane-use-pydantic-v2-type
Conversation
This is a follow-up to #1752 and supersedes #1759. It's understood that `string` type is no longer being treated as a list by Pydantic. `bytes` should be. The code generator seems aware of the `bytes` type [1][2]. [1] https://github.com/koxudaxi/datamodel-code-generator/blob/fcab9a4d555d4b96d64bb277f974bb7507982fb2/datamodel_code_generator/types.py#L536-L569 [2] https://github.com/koxudaxi/datamodel-code-generator/blob/fcab9a4d555d4b96d64bb277f974bb7507982fb2/datamodel_code_generator/types.py#L624-L640
RobertSamoilescu
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1752 and supersedes #1759.
It's understood that
stringtype is no longer being treated as a list by Pydantic.bytesshould be.The code generator seems aware of the
bytestype [1][2].[1] https://github.com/koxudaxi/datamodel-code-generator/blob/fcab9a4d555d4b96d64bb277f974bb7507982fb2/datamodel_code_generator/types.py#L536-L569
[2] https://github.com/koxudaxi/datamodel-code-generator/blob/fcab9a4d555d4b96d64bb277f974bb7507982fb2/datamodel_code_generator/types.py#L624-L640