Fix signature codec with tuple type annotations#1064
Merged
adriangonz merged 2 commits intoSeldonIO:masterfrom Apr 4, 2023
sauerburger:tuple_type_check
Merged
Fix signature codec with tuple type annotations#1064adriangonz merged 2 commits intoSeldonIO:masterfrom sauerburger:tuple_type_check
adriangonz merged 2 commits intoSeldonIO:masterfrom
sauerburger:tuple_type_check
Conversation
Contributor
|
Nice one! Thanks a lot for following up with this PR @sauerburger . Changes look great! 🚀 For the tests, perhaps you can add a new one for the |
adriangonz
approved these changes
Apr 4, 2023
Contributor
adriangonz
left a comment
There was a problem hiding this comment.
Nice one @sauerburger ! Thanks for making those changes.
PR looks great. Once tests are green, it should be good to go ahead. 👍
Contributor
Author
|
Thanks for the kind feedback. I've fixed the issue that triggered the linter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1036
I'm unsure how/where to add a test for this as I didn't manage to run the test suite. Locally, I've experimented with the following snippet.
Please note: The notation for the
predict_fn_native_tupletest requires Python 3.9. The PR code, however, does not depend on Python 3.9.