Changed default CRS for set_extent so it is no longer the geodetic version.#131
Closed
esc24 wants to merge 4 commits intoSciTools:masterfrom
Closed
Changed default CRS for set_extent so it is no longer the geodetic version.#131esc24 wants to merge 4 commits intoSciTools:masterfrom
esc24 wants to merge 4 commits intoSciTools:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the extent of a plot with
GeoAxes.set_extent()the CRS of the provided coords currently defaults to a geodetic version ofself.projectionrather thanself.projection. I do not see the reason for this and in my opinion the behaviour is unexpected. I propose changing it so that if I set up an axes in projection X, any provided extent is assumed to be in that coordinate system unless I explicitly tell it otherwise through thecrsargument.