Respect caller timestamp options in batched transcribe#1428
Open
ponpaku wants to merge 1 commit intoSYSTRAN:masterfrom
Open
Respect caller timestamp options in batched transcribe#1428ponpaku wants to merge 1 commit intoSYSTRAN:masterfrom
ponpaku wants to merge 1 commit intoSYSTRAN:masterfrom
Conversation
2b3f513 to
519481d
Compare
519481d to
58d1fe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores caller-provided
condition_on_previous_textandmax_initial_timestampinBatchedInferencePipeline.transcribe().Related issue: #1427
Previously, the batched path hardcoded these values instead of using the caller request, making it behaviorally non-equivalent to
WhisperModel.transcribe()for timestamped decoding.What this PR changes
condition_on_previous_textin batched transcription optionsmax_initial_timestampin batched transcription optionsWhat this PR does not try to solve
This PR is intentionally narrow.
It does not attempt to fix all direct/batched quality gaps such as:
Validation
pytest