Fix DSC_RESOURCE_PATH env var to also limit exe search#825
Merged
SteveL-MSFT merged 4 commits intoPowerShell:mainfrom Jun 4, 2025
Merged
Fix DSC_RESOURCE_PATH env var to also limit exe search#825SteveL-MSFT merged 4 commits intoPowerShell:mainfrom
DSC_RESOURCE_PATH env var to also limit exe search#825SteveL-MSFT merged 4 commits intoPowerShell:mainfrom
Conversation
Member
Author
|
Looks like a bunch of tests relied on the previous behavior and I'll need to fix them |
3576c17 to
ca2473d
Compare
tgauth
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The original intent of
DSC_RESOURCE_PATHwas to constrain searching not only manifests but also executables to the paths of that env var. However, the current code only used it for finding resource manifests and relied on the existingPATHto find executables.The change is to set the process
PATHenv var to same asDSC_RESOURCE_PATHsuch that the original intent is respected. We should make this clear in the docs. If the user wants to temporarily add toPATHusing this env var, they should appendPATHto it like:PR Context
Fix #814