Add fix to return enum string values#800
Merged
SteveL-MSFT merged 15 commits intoPowerShell:mainfrom May 21, 2025
Merged
Conversation
Collaborator
Author
|
@mgreenegit I'm bothering Steve too much, so I thought of giving you a heads-up. Could you take a quick look at this one? It shouldn't be that big of a change. |
SteveL-MSFT
requested review from
mgreenegit,
michaeltlombardi and
theJasonHelmick
Collaborator
michaeltlombardi
left a comment
michaeltlombardi
left a comment
There was a problem hiding this comment.
Minor nits for readability and spacing characters.
Collaborator
Author
|
Thanks @michaeltlombardi for the check. I thought there was a remark once to do it in the style Pester tests are written (OTBS). I switched the blocks in |
michaeltlombardi
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses #791. While it is a small redesign, casting the value to a string makes logical sense. When users are exporting or getting values, they can capture the results and store them as a configuration document instead of having them returned as integers. This would match the schematics, even though that is not implemented fully.