Fixed invoke_command to support resources with more than 64 char output#68
Merged
SteveL-MSFT merged 1 commit intomainfrom Apr 21, 2023
Merged
Fixed invoke_command to support resources with more than 64 char output#68SteveL-MSFT merged 1 commit intomainfrom
SteveL-MSFT merged 1 commit intomainfrom
Conversation
SteveL-MSFT
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
std::process::Commandhangs inchild.wait()if the subprocess prints more than 64K characters to stdout.The fix is to read the output (therefore making space for the child process to put put more data) before waiting for the child process exit.
Verified the fix by running
pwshwithGet-DscResource | ConvertTo-Json -Depth 3, which was hanging previously.