Update WMI adapter to perform query based on provided properties#548
Merged
SteveL-MSFT merged 5 commits intoPowerShell:mainfrom Sep 17, 2024
Merged
Update WMI adapter to perform query based on provided properties#548SteveL-MSFT merged 5 commits intoPowerShell:mainfrom
SteveL-MSFT merged 5 commits intoPowerShell:mainfrom
Conversation
anmenaga
approved these changes
Sep 17, 2024
| $stdinput | ||
| ) | ||
|
|
||
| trap { |
There was a problem hiding this comment.
Would be good to have a comment about what this trap does.
Member
Author
There was a problem hiding this comment.
ok, will add comment
| adaptertype: | ||
| netconnectionid: | ||
| serviceName: | ||
| netconnectionstatus: 2 |
There was a problem hiding this comment.
Is my understanding correct that this is the only instance in this file that will use WHERE clause?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously, all the properties for a WMI class gets returned. With this change, the specified properties get turned into a query. This can actually improve performance if the WMI provider supports it, but otherwise it also means the output won't have information that the configuration did not request.
If a property has a value, then that value is used as part of the query.
Example output using the updated wmi inventory example:
Also fixed how the adapter writes traces so they show up correctly.
PR Context
Address a part of #475