Blocked non-list operations on adapters#525
Merged
SteveL-MSFT merged 13 commits intoPowerShell:mainfrom Aug 30, 2024
Merged
Conversation
17f211c to
72bb968
Compare
SteveL-MSFT
requested changes
Aug 22, 2024
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Seems like the check should be in the lib instead of the exe, perhaps here? https://github.com/PowerShell/DSC/blob/main/dsc_lib/src/dscresources/dscresource.rs#L190
Author
I've tried this, but realized that because the way we call adapted resources (we substitute adapted resource with adapter before calling lib's get/set/etc...) a way to differentiate between a call on an adapted resource vs call on an adapter within the lib is not trivial and I think it's not worth it. |
added 3 commits
August 30, 2024 11:07
SteveL-MSFT
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #516
Currently when non-list operations are executed on an adapter the error message is misleading;
This PR adds a check early in the call chain and prints a clear error message.
For example: