Merged
Conversation
4e70e7f to
e505e49
Compare
SteveL-MSFT
requested changes
Jun 12, 2024
Collaborator
|
What about cases where people split their module code without using For example, the pattern built by the DSC Community has base classes etc defined in a sub-module and has using/import statements to retrieve the code: |
Author
|
e505e49 to
eb2af32
Compare
SteveL-MSFT
approved these changes
Jun 16, 2024
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
We can address other issues as separate PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Some PS modules do not specify
RootModulein theirpsd1.In such cases
Get-Modulefills inRootModulewith full path topsd1, which is misleading for discovering class-based resources.This was causing internal failures in PsDscAdapter.
This PR fixes that with explicit check for such condition and adds some tracing to make diagnostics easier.