Skip to content
This repository was archived by the owner on Jul 4, 2023. It is now read-only.

Updating FastText URLs#72

Merged
PetrochukM merged 2 commits intoPetrochukM:masterfrom
crleblanc:updated-fasttext-urls
Apr 29, 2019
Merged

Updating FastText URLs#72
PetrochukM merged 2 commits intoPetrochukM:masterfrom
crleblanc:updated-fasttext-urls

Conversation

@crleblanc
Copy link
Copy Markdown

This PR fixes #70 by using updated URLs for downloading the fasttext vectors and aligned vectors (as per https://github.com/facebookresearch/fastText/blob/master/docs/pretrained-vectors.md).

A quick manual test shows that it's working as expected.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 29, 2019

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files          57       57           
  Lines        1523     1523           
=======================================
  Hits         1434     1434           
  Misses         89       89
Impacted Files Coverage Δ
torchnlp/word_to_vector/fast_text.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c432c3e...80049bf. Read the comment docs.

Copy link
Copy Markdown
Owner

@PetrochukM PetrochukM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@PetrochukM PetrochukM merged commit 5f7320d into PetrochukM:master Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Http 403 when calling FastText()

3 participants