Merged
Conversation
rouault
added
the
funded through GSP
rouault
force-pushed
the
cpp_17
branch
5 times, most recently
from
396c56d to
af1a5e9
Compare
rouault
force-pushed
the
cpp_17
branch
2 times, most recently
from
170fe4c to
4041014
Compare
…false-positive from CSA
The immediate driver for this change is related when fetching GTest. Currently we are stuck with GTest-1.12.1 because is the latest version supporting C++11. Later versions require C++14. However, GTest-1.12.1 has a CMakeLists.txt with ``cmake_minimum_required(VERSION 3.5)`` which causes the following warning with modern CMake versions: ``` CMake Deprecation Warning at build/_deps/googletest-src/CMakeLists.txt:4 (cmake_minimum_required): Compatibility with CMake < 3.10 will be removed from a future version of CMake. ``` Updating to >= C++14 allows us to use GTest-1.15.2 which has a ``cmake_minimum_required(VERSION 3.13)``
jjimenezshaw
reviewed
Jan 3, 2025
This was referenced Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The immediate driver for this change is related when fetching GTest. Currently we are stuck with GTest-1.12.1 because is the latest version supporting C++11. Later versions require C++14.
However, GTest-1.12.1 has a CMakeLists.txt with
cmake_minimum_required(VERSION 3.5)which causes the following warning with modern CMake versions:Updating to >= C++14 allows us to use GTest-1.15.2 which has a
cmake_minimum_required(VERSION 3.13)