fix: move stop_reason checking logic before list truncation#81
Merged
SumanthRH merged 1 commit intoNovaSky-AI:mainfrom Jul 12, 2025
hank0316:main
Merged
fix: move stop_reason checking logic before list truncation#81SumanthRH merged 1 commit intoNovaSky-AI:mainfrom hank0316:main
stop_reason checking logic before list truncation#81SumanthRH merged 1 commit intoNovaSky-AI:mainfrom
hank0316:main
Conversation
fannie1208
pushed a commit
to vinid/SkyRL
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that
stop_reasonis set before truncatingloss_maskandresponse_idsto maintain correct logic and avoid inconsistencies.