[Cleanup] Many small fixes and improvements#64
Merged
tyler-griggs merged 4 commits intomainfrom Jul 7, 2025
Merged
Conversation
erictang000
approved these changes
Jul 7, 2025
Collaborator
erictang000
left a comment
erictang000
left a comment
There was a problem hiding this comment.
nice, everything makes sense to me, thanks!
Could you double check/link to a training run (multiply or gsm8k with the latest changes) just to make sure nothing is breaking?
fannie1208
pushed a commit
to vinid/SkyRL
that referenced
this pull request
Aug 19, 2025
Iterating on several small pieces of feedback from users, especially around clarity of documentation for creating a new environment. This PR also changes the default setting of `generator.batched` to `false`. Reasoning: a couple users have been surprised by low performance on tool-use and multi-turn tasks. The root-cause was simply that `batched` was at its default setting of `true`. Because we focus on multi-turn, tool-use agentic tasks (rather than single-turn tasks), we should default this to `false`. Wandb link for gsm8k: https://wandb.ai/sky-posttraining-uc-berkeley/gsm8k/runs/navm8ull?nw=nwuserskyposttraining
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterating on several small pieces of feedback from users, especially around clarity of documentation for creating a new environment.
This PR also changes the default setting of
generator.batchedtofalse. Reasoning: a couple users have been surprised by low performance on tool-use and multi-turn tasks. The root-cause was simply thatbatchedwas at its default setting oftrue. Because we focus on multi-turn, tool-use agentic tasks (rather than single-turn tasks), we should default this tofalse.Wandb link for gsm8k: https://wandb.ai/sky-posttraining-uc-berkeley/gsm8k/runs/navm8ull?nw=nwuserskyposttraining