[Docs] add system overview doc (pt. 1)#50
Merged
tyler-griggs merged 2 commits intomainfrom Jun 26, 2025
Merged
Conversation
SumanthRH
reviewed
Jun 26, 2025
| ~~~~~~~ | ||
| Performs the optimization steps based on configured RL algorithm. Updates model parameters based on generated trajectories and their assigned rewards. | ||
|
|
||
| - `Trainer Worker interface <https://github.com/NovaSky-AI/SkyRL/blob/main/skyrl-train/skyrl_train/workers/worker.py#L162>`_ |
Member
There was a problem hiding this comment.
What do you think about adding the Trainer class here?
Member
There was a problem hiding this comment.
Ok that is the controller. Got it.
Isn't the main abstraction the ActorGroup and not Worker? Can we add ActorGroup here
SumanthRH
approved these changes
Jun 26, 2025
fannie1208
pushed a commit
to vinid/SkyRL
that referenced
this pull request
Aug 19, 2025
Mostly copying from the blog post. Second pass will actually give detail on the control flow between components, and perhaps blurbs on (or pointers to) data formats for transfers between components. <img width="697" alt="Screenshot 2025-06-26 at 11 35 52 AM" src="https://github.com/user-attachments/assets/7c484548-5986-4e30-8f8b-ba4f1c472c18" /> <img width="693" alt="Screenshot 2025-06-26 at 11 35 56 AM" src="https://github.com/user-attachments/assets/3967fb00-b09c-4af5-8f8e-c9e154f21e69" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly copying from the blog post. Second pass will actually give detail on the control flow between components, and perhaps blurbs on (or pointers to) data formats for transfers between components.