Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the SkyPilot configuration to support multi-node execution. The changes include increasing num_nodes to 2, configuring workdir to automatically clone the git repository, and dynamically calculating the number of inference engines for a multi-node setup. The documentation is also updated to reflect these simplifications. The changes are logical and improve the multi-node configuration. My feedback is focused on a minor style issue in the YAML configuration to improve readability and maintainability.
SumanthRH
approved these changes
Oct 16, 2025
li-boxuan
pushed a commit
to li-boxuan/SkyRL
that referenced
this pull request
Nov 23, 2025
Test GSM8k with 2 node in Skypilot --------- Co-authored-by: Andy Lee <andylizf@outlook.com>
dzorlu
pushed a commit
to fleet-ai/SkyRL
that referenced
this pull request
Feb 4, 2026
Test GSM8k with 2 node in Skypilot --------- Co-authored-by: Andy Lee <andylizf@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test GSM8k with 2 node in Skypilot