[fix] Resolve timeout and cleanup issues in GPU CI pipeline#483
Merged
erictang000 merged 2 commits intoNovaSky-AI:mainfrom Oct 15, 2025
Merged
[fix] Resolve timeout and cleanup issues in GPU CI pipeline#483erictang000 merged 2 commits intoNovaSky-AI:mainfrom
erictang000 merged 2 commits intoNovaSky-AI:mainfrom
Conversation
tyler-griggs
commented
Oct 15, 2025
Member
Author
There was a problem hiding this comment.
This diff looks messy, but it was mostly just removing the try/except and un-indenting the rest of the tests
tyler-griggs
commented
Oct 15, 2025
| **lora_kwargs, | ||
| ) | ||
| inference_engine_actors.append(engine) | ||
| engine = actor_class.options( |
Member
Author
There was a problem hiding this comment.
Embarrassing indent error in the dp engine creation path..
| server_process = subprocess.Popen(remote_server_command, env=env) | ||
|
|
||
| wait_for_server(url=f"localhost:{engine_port}", health_path="health") | ||
| wait_for_server(url=f"localhost:{engine_port}", health_path="health", timeout=120) |
Member
Author
There was a problem hiding this comment.
bump timeout from 60s to 120s because our tp=2,dp=2 runs were taking ~63s
li-boxuan
pushed a commit
to li-boxuan/SkyRL
that referenced
this pull request
Nov 23, 2025
…AI#483) The primary change was to remove the bespoke ways that different tests are setting up and tearing down resources (e.g,. `ray.init()`, `ray.shutdown()`), and in this PR we instead prefer the use of `ray_init_fixture`. This also fixes an indent error in the creation of dp>1 Ray-wrapped inference engines.
Merged
dzorlu
pushed a commit
to fleet-ai/SkyRL
that referenced
this pull request
Feb 4, 2026
…AI#483) The primary change was to remove the bespoke ways that different tests are setting up and tearing down resources (e.g,. `ray.init()`, `ray.shutdown()`), and in this PR we instead prefer the use of `ray_init_fixture`. This also fixes an indent error in the creation of dp>1 Ray-wrapped inference engines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary change was to remove the bespoke ways that different tests are setting up and tearing down resources (e.g,.
ray.init(),ray.shutdown()), and in this PR we instead prefer the use ofray_init_fixture.This also fixes an indent error in the creation of dp>1 Ray-wrapped inference engines.