[Sequence parallel][train] Support sequence parallelism without sample packing#480
Merged
SumanthRH merged 5 commits intoNovaSky-AI:mainfrom Oct 15, 2025
Merged
Conversation
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully extends sequence parallelism to support operation without sample packing. The changes are logical and well-implemented across the affected files. Key modifications include generalizing padding and slicing utilities to handle batch sizes greater than one, updating the model wrapper to correctly manage attention masks and gather outputs in both packed and non-packed scenarios, and adding a necessary re-computation of query_length for flash attention. The accompanying test enhancements are thorough, covering both with and without sample packing cases. I have one minor suggestion to update a docstring for consistency.
1 task
li-boxuan
pushed a commit
to li-boxuan/SkyRL
that referenced
this pull request
Nov 23, 2025
…vaSky-AI#480) Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
dzorlu
pushed a commit
to fleet-ai/SkyRL
that referenced
this pull request
Feb 4, 2026
…vaSky-AI#480) Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.