[fix] Bring back pretty log formatting#250
Merged
SumanthRH merged 4 commits intoNovaSky-AI:mainfrom Sep 8, 2025
Merged
Conversation
tyler-griggs
changed the title
SumanthRH
reviewed
Sep 8, 2025
Comment on lines
+501
to
+502
| logging.root.handlers = [_InterceptHandler()] | ||
| logging.root.setLevel(logging.INFO) |
Member
There was a problem hiding this comment.
Hmm if I'm debugging and I set LOG_LEVEL=DEBUG in my env file, this will override the root logger to use INFO?
Maybe set it only if LOG_LEVEL is not set?
SumanthRH
approved these changes
Sep 8, 2025
CharlieFRuan
added a commit
that referenced
this pull request
Sep 8, 2025
This reverts commit 5d9888d.
CharlieFRuan
added a commit
that referenced
this pull request
Sep 8, 2025
Reverts #250 Will run into ` AssertionError: The env var, __RAY_WORKER_PROCESS_SETUP_HOOK_ENV_VAR, is not permitted because it is reserved for the internal use.`
tyler-griggs
added a commit
that referenced
this pull request
Sep 11, 2025
Re-implement the logging fix of #250 that was reverted in #261 The issue was that using the `worker_process_setup_hook` to set logging behavior interfered with vLLM using Ray as it's tensor parallel backend and threw an error. vLLM apparently needs this to be unset. Moved the logging configuration into RayPPOTrainer `init`.
ztcanddota
added a commit
to ztcanddota/skyagent
that referenced
this pull request
Sep 28, 2025
Reverts NovaSky-AI/SkyRL#250 Will run into ` AssertionError: The env var, __RAY_WORKER_PROCESS_SETUP_HOOK_ENV_VAR, is not permitted because it is reserved for the internal use.`
SungjunlaLee
added a commit
to SungjunlaLee/SkyRL
that referenced
this pull request
Jan 3, 2026
Reverts NovaSky-AI/SkyRL#250 Will run into ` AssertionError: The env var, __RAY_WORKER_PROCESS_SETUP_HOOK_ENV_VAR, is not permitted because it is reserved for the internal use.`
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
Brings back nicely-formatted logs (ie, coloring, bold, etc.) that was lost when the training loop moved off the head node. Old: <img width="1210" height="196" alt="Screenshot 2025-09-07 at 12 52 00 PM" src="https://github.com/user-attachments/assets/e121e0f1-17d3-42c7-98ab-0e739af1be97" /> New: <img width="1460" height="673" alt="Screenshot 2025-09-07 at 4 30 04 PM" src="https://github.com/user-attachments/assets/6869a050-15f0-4e17-955d-9e5046fe42e4" />
dzorlu
pushed a commit
to fleet-ai/SkyRL
that referenced
this pull request
Feb 4, 2026
Reverts NovaSky-AI#250 Will run into ` AssertionError: The env var, __RAY_WORKER_PROCESS_SETUP_HOOK_ENV_VAR, is not permitted because it is reserved for the internal use.`
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
Re-implement the logging fix of #250 that was reverted in #261 The issue was that using the `worker_process_setup_hook` to set logging behavior interfered with vLLM using Ray as it's tensor parallel backend and threw an error. vLLM apparently needs this to be unset. Moved the logging configuration into RayPPOTrainer `init`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings back nicely-formatted logs (ie, coloring, bold, etc.) that was lost when the training loop moved off the head node.
Old:
New:
