Skip to content

1/N GPU CI Migration#195

Merged
tyler-griggs merged 5 commits intoNovaSky-AI:mainfrom
tyler-griggs:gpu_ci_1
Aug 25, 2025
Merged

1/N GPU CI Migration#195
tyler-griggs merged 5 commits intoNovaSky-AI:mainfrom
tyler-griggs:gpu_ci_1

Conversation

@tyler-griggs
Copy link
Member

@tyler-griggs tyler-griggs commented Aug 25, 2025

Migrating a first batch of tests over to gpu_ci, for #199

@tyler-griggs tyler-griggs marked this pull request as ready for review August 25, 2025 05:20
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test_skyrl_gym_generator test uses the SearchR1 dataset, but only the test split (which is much smaller than the train split), so this change enables only downloaded the test split

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is just a copy-paste of the original SkyRL Gym test, but left behind on test (text2sql) that needs to be made more lightweight before transferring over

@SumanthRH SumanthRH self-requested a review August 25, 2025 05:28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how much time does this take on L4 now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I measured the full block of migrated tests (the 5 files in this PR), which was originally 41min but is now 23min. Still quite slow but... a start.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sg, let's revisit once all files are moved over

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and added this as step 2 in the issue

@tyler-griggs tyler-griggs merged commit f5ad917 into NovaSky-AI:main Aug 25, 2025
3 checks passed
dzorlu referenced this pull request in fleet-ai/SkyRL Feb 4, 2026
Migrating a first batch of tests over to `gpu_ci`, for #199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants