[DAPO] Fix data preprocess script #172
Merged
lynnliu030 merged 16 commits intoNovaSky-AI:mainfrom Aug 20, 2025
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new AIME environment for math execution tasks, along with data preparation and training scripts. The changes are generally well-structured. My feedback focuses on improving robustness, efficiency, and correctness. Key points include:
- Using proper error handling instead of assertions in the
AIMEEnv. - Correcting a type hint in the
aime.utilsmodule. - Improving the efficiency of the data preprocessing script by using
polarsfor I/O directly. - Making the data download script idempotent.
- Enhancing the main run script for better error handling and to include the data preprocessing step.
SumanthRH
approved these changes
Aug 20, 2025
SumanthRH
reviewed
Aug 20, 2025
Member
There was a problem hiding this comment.
can you rename this to data_preprocess_aime?
Or rather, we could just have a separate aime folder in examples
Member
Author
There was a problem hiding this comment.
done, I just make it data_preprocess_dapo_aime.py
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.