Merged
Conversation
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes environment variable definitions into a common skyrl.env_vars module, which is a great refactoring effort that removes duplication and significantly improves code maintainability. No security vulnerabilities were found in this change. I have a couple of suggestions to further improve code style by moving local imports to the top of the file, in line with PEP 8 guidelines.
| go to stdout. | ||
| """ | ||
| from skyrl.train.env_vars import SKYRL_DUMP_INFRA_LOG_TO_STDOUT | ||
| from skyrl.env_vars import SKYRL_DUMP_INFRA_LOG_TO_STDOUT |
Contributor
There was a problem hiding this comment.
For better code readability and adherence to PEP 8, this local import should be moved to the top of the file. Since skyrl.env_vars is a lightweight module without circular dependency risks here, a top-level import is preferred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes duplicated
env_varsfile and makes them common