[megatron] refactor megatron param/grad offload to directly use new megatron built in functions#1266
Merged
erictang000 merged 2 commits intoNovaSky-AI:mainfrom Mar 3, 2026
Conversation
erictang000
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
tyler-griggs
pushed a commit
that referenced
this pull request
Mar 5, 2026
…x) and PR #1266 (megatron offload refactor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrading to megatron-core==0.16.0 temporarily broke grad offloading code in specific cases due to new grad/param buffer offloading logic built in to megatron-core. Refactors our param/grad offload logic to use megatron builtins from: NVIDIA/Megatron-LM#3112
Fixes
tests/backends/skyrl_train/gpu/gpu_ci/test_worker_dispatch_offload.py::test_dispatch_set_lrtest which previously was encountering an error when offloading grad.Offloading test still passes
Before
After