[train] Remove deprecated skyrl-train package#1249
Merged
Conversation
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
…e-skyrl-train Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
SumanthRH
force-pushed
the
remove-skyrl-train
branch
from
2f7d9db to
914e426
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated skyrl-train package as part of a codebase reorganization. The changes involve deleting the package's source code, examples, and CI scripts. The .gitignore file and the skyrl-train/README.md have been updated to reflect the removal of the package and guide users to the new code locations. My review focused on the correctness of the remaining file modifications. The path updates in the README and the removals from .gitignore appear consistent with the new project structure.
Note: Security Review is unavailable for this PR.
tyler-griggs
pushed a commit
that referenced
this pull request
Mar 10, 2026
Restores two changes from PRs #1215 and #1240 that were dropped when skyrl-train/ was removed in #1249: - Add GLM-4.7-Flash Megatron GRPO example script (PR #1215), adapted for the new skyrl.train entrypoint and config key format. - Restore numpy>=2.0.0 override-dependency (PR #1240), needed because vLLM 0.16.0 transitively requires numpy>=2 via opencv-python-headless while megatron-core pins numpy<2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the old
skyrl-trainpackage now that we have finished migrating code to the newskyrlpackage.I've retained the old README for reference with some path updates. There are still some references to
skyrl-trainhere which is fine for now.