Skip to content

[tx] Update README.md and move tx over to skyrl/ folder#1226

Merged
pcmoritz merged 5 commits intoNovaSky-AI:mainfrom
pcmoritz:skyrl-tx-remove-folder
Feb 26, 2026
Merged

[tx] Update README.md and move tx over to skyrl/ folder#1226
pcmoritz merged 5 commits intoNovaSky-AI:mainfrom
pcmoritz:skyrl-tx-remove-folder

Conversation

@pcmoritz
Copy link
Copy Markdown
Collaborator

@pcmoritz pcmoritz commented Feb 26, 2026

This completes #1145 for the skyrl-tx folder.

For users, all that is required to update is to run in the SkyRL base folder, and replace -m tx.tinker.api with -m skyrl.tinker.api in the command line. See the updates to the README: https://github.com/NovaSky-AI/SkyRL/pull/1226/changes#diff-3ab5f33c37f9cfd1a0e08eef29bf8a2fcbde1b7e140b49f966b3740e82b43f3bL61

The code that was previously in the skyrl-tx folder can now be found in skyrl/{backends, tinker, tx, utils}.


Open with Devin

gemini-code-assist[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@pcmoritz pcmoritz added the tx label Feb 26, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@pcmoritz
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant refactoring that moves the tx package into the skyrl/ folder, unifying the codebase. The changes primarily involve removing files from the old skyrl-tx directory and updating the README.md to reflect the new package structure. The command updates in the README are correct. However, I've identified an incorrect GitHub link in the README that will be broken after the refactoring and have suggested a fix. Overall, this is a good step towards a more organized repository structure.


- **Slack**: [#skyrl-tx](https://skyrl.slack.com/archives/C09K1JGNPJS)
- **GitHub**: [NovaSky-AI/SkyRL/skyrl-tx](https://github.com/NovaSky-AI/SkyRL/tree/main/skyrl-tx)
- **GitHub**: [NovaSky-AI/SkyRL/skyrl-tx](https://github.com/NovaSky-AI/SkyRL/tree/main/skyrl-tx/README.md)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The GitHub link seems to be incorrect. Since the skyrl-tx folder is being moved to skyrl/, this link will be broken. It should probably point to the new skyrl directory, and the link text should be updated accordingly.

Suggested change
- **GitHub**: [NovaSky-AI/SkyRL/skyrl-tx](https://github.com/NovaSky-AI/SkyRL/tree/main/skyrl-tx/README.md)
- **GitHub**: [NovaSky-AI/SkyRL/skyrl](https://github.com/NovaSky-AI/SkyRL/tree/main/skyrl)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md file is actually kept around :)

@pcmoritz pcmoritz merged commit f3f2dbf into NovaSky-AI:main Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant