[train][tests] Fix hanging test test_abort_generation_vllm_engine #1202
Merged
CharlieFRuan merged 3 commits intomainfrom Feb 24, 2026
Merged
[train][tests] Fix hanging test test_abort_generation_vllm_engine #1202CharlieFRuan merged 3 commits intomainfrom
test_abort_generation_vllm_engine #1202CharlieFRuan merged 3 commits intomainfrom
Conversation
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
SumanthRH
changed the title
test_abort_generation_vllm_engine test_abort_generation_vllm_engine
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a hanging test, test_abort_generation_vllm_engine, by correctly modifying the calls to chat_completion and completion. The original implementation called these methods on the client object, which contains retry logic that led to a deadlock when generation was paused. The fix is to call the methods directly on the underlying engine (client.engines[0]), bypassing the problematic retry logic. This change is correct and effectively resolves the issue in the test. The changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes hanging test
test_abort_generation_vllm_engine. Currently this test sends 4 requests toInferenceEngineInterface.chat_completion, callspause_generationand waits for the requests to finish. However,chat_completionmethod has an infinite retry loop to wait until the engine is back online - causing a deadlock.We need to use
client.engines[0].chat_completionhere .