-
Notifications
You must be signed in to change notification settings - Fork 286
[train] Pythonic Configs 2/N: Switch to new dataclasses in entrypoint scripts; Change instantiation signatures #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 53 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
bd462d3
use new SkyRL config in the main script; add new InferenceEngineConfi…
SumanthRH 08bbcca
[train] Pythonic Configs 2/N - Migrate all examples, core modules, an…
SumanthRH ad93f7f
[train] Pythonic Configs 3/N - Remove DictConfig from all type hints,…
SumanthRH e27339d
latest progress
SumanthRH e3759c4
[train] Pythonic Configs 4/N - Fix worker subclass config paths and u…
SumanthRH 4a816cf
Merge upstream/main into pythonic-configs-vv1
SumanthRH bc2dea2
Port pythonic configs migration from skyrl-train to skyrl folder
SumanthRH c449c90
x
SumanthRH 66745b1
Merge upstream/main into pythonic-configs-vv1
SumanthRH 9792d7d
Fix config field access bugs across skyrl-train and skyrl
SumanthRH 9d356ab
Migrate examples/train scripts to pythonic config, fix config default…
SumanthRH 40c4ca3
x
SumanthRH 5433959
x
SumanthRH 0c7ade5
Merge upstream/main: resolve docs conflicts by accepting upstream del…
SumanthRH 548327f
Update docs to reflect pythonic config migration
SumanthRH 060c54d
Merge remote-tracking branch 'upstream/main' into pythonic-configs-vv1
SumanthRH ebb58c6
Add configuration API reference docs for pythonic config classes
SumanthRH c6f1486
Fix cross-field config defaults lost in YAML-to-dataclass migration
SumanthRH bb7506a
Merge remote-tracking branch 'upstream/main' into pythonic-configs-vv1
SumanthRH 70dfe05
Don't change skyrl-train
SumanthRH 8588f6e
fix cross field defaults
SumanthRH 5c6cfca
x
SumanthRH b2410f1
fix backend dtypes; fix megatron test
SumanthRH 0b0edce
x
SumanthRH 4bc25da
more fixes
SumanthRH d1e995d
x
SumanthRH 12711cb
x
SumanthRH 11d12de
fix skyrl train backend
SumanthRH 4153277
renaming
SumanthRH 1cff09d
x
SumanthRH e6fc36b
x
SumanthRH 5bf149b
Update skyrl/train/config/config.py
SumanthRH 2c8fcb3
Update skyrl/train/config/config.py
SumanthRH c99183b
Update skyrl/train/config/config.py
SumanthRH e04bca2
x
SumanthRH 00b3580
Merge remote-tracking branch 'upstream/main' into pythonic-configs-vv1
SumanthRH f067dad
x
SumanthRH 966bd02
x
SumanthRH b0c7c92
fix default value for sampling params
SumanthRH 8a29e0c
revert change
SumanthRH 030a568
revert skyrl-train changes
SumanthRH e31f155
x
SumanthRH cb523b2
remove prints
SumanthRH 5aab05b
Migrate examples/ off Hydra to pythonic dataclass configs
SumanthRH f426aff
x
SumanthRH d07108e
x
SumanthRH a833669
x
SumanthRH c73bd9d
x
SumanthRH c9fd166
x
SumanthRH 14f8f9b
x
SumanthRH 7ec226e
x
SumanthRH 43ac8ab
Merge remote-tracking branch 'upstream/main' into pythonic-configs-vv1
SumanthRH 1655229
x
SumanthRH 16edac0
Update skyrl/backends/skyrl_train/workers/worker.py
SumanthRH 76865e8
x
SumanthRH 77a72ef
fix max seq len test
SumanthRH 9ea2c39
remove model name arg
SumanthRH 397edf7
switch to ray init fixture
SumanthRH 50e8b09
Merge remote-tracking branch 'upstream/main' into pythonic-configs-vv1
SumanthRH c52fe54
self review
SumanthRH 5e711df
revert skyrl-agent change
SumanthRH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,227 @@ | ||
| # Configuration Reference | ||
|
|
||
| SkyRL-Train uses Python dataclasses for configuration. The top-level | ||
| `SkyRLTrainConfig` mirrors the YAML configuration structure and can be | ||
| constructed from YAML files, CLI overrides, or plain dicts. | ||
|
|
||
| ## Top-Level Config | ||
|
|
||
| ::: skyrl.train.config.SkyRLTrainConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ## Trainer | ||
|
|
||
| ::: skyrl.train.config.TrainerConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Placement | ||
|
|
||
| ::: skyrl.train.config.PlacementConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Policy / Critic / Ref | ||
|
|
||
| ::: skyrl.train.config.PolicyConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.CriticConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.RefConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Model & LoRA | ||
|
|
||
| ::: skyrl.train.config.ModelConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.SkyRLLoraConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Optimizer & Mixed Precision | ||
|
|
||
| ::: skyrl.train.config.OptimizerConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.MixedPrecisionConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### FSDP | ||
|
|
||
| ::: skyrl.train.config.FSDPConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Megatron | ||
|
|
||
| ::: skyrl.train.config.MegatronConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.MegatronDDPConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.MegatronLoraConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.MegatronTorchProfilerConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Algorithm | ||
|
|
||
| ::: skyrl.train.config.AlgorithmConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.SAPOConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.CISPOConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.ClipCovConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.KLCovConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.KLCtrlConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.DynamicSamplingConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.OffPolicyCorrectionConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Fully Async | ||
|
|
||
| ::: skyrl.train.config.FullyAsyncConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ## Generator | ||
|
|
||
| ::: skyrl.train.config.GeneratorConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Inference Engine | ||
|
|
||
| ::: skyrl.train.config.InferenceEngineConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ### Sampling | ||
|
|
||
| ::: skyrl.train.config.SamplingParams | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.ChatTemplateConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ## Environment | ||
|
|
||
| ::: skyrl.train.config.EnvironmentConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ::: skyrl.train.config.SkyRLGymConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ## Data | ||
|
|
||
| ::: skyrl.train.config.DataConfig | ||
| options: | ||
| show_root_heading: true | ||
| members_order: source | ||
| show_bases: true | ||
|
|
||
| ## Utilities | ||
|
|
||
| ::: skyrl.train.config.config.make_config | ||
| options: | ||
| show_root_heading: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.