Port https://github.com/NovaSky-AI/SkyRL/pull/1144 to skyrl folder#1169
Merged
pcmoritz merged 2 commits intoNovaSky-AI:mainfrom Feb 17, 2026
Merged
Port https://github.com/NovaSky-AI/SkyRL/pull/1144 to skyrl folder#1169pcmoritz merged 2 commits intoNovaSky-AI:mainfrom
pcmoritz merged 2 commits intoNovaSky-AI:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully ports the CISPO loss function, integrating it across the api.py, loss_fns.py, and types.py files. The changes include updating the ForwardBackwardInput model to accept 'cispo' as a valid loss function, implementing the cispo_loss function itself, and adding 'cispo' to the relevant mappings. Furthermore, the test suite in test_engine.py has been refactored to use pytest.mark.parametrize, which improves test coverage and maintainability for different loss functions, including the newly added CISPO. The implementation is consistent with existing patterns and appears correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1144