[train][vllm] Add enable_log_requests and max_log_len support#1071
Merged
CharlieFRuan merged 1 commit intoNovaSky-AI:mainfrom Feb 11, 2026
Merged
[train][vllm] Add enable_log_requests and max_log_len support#1071CharlieFRuan merged 1 commit intoNovaSky-AI:mainfrom
CharlieFRuan merged 1 commit intoNovaSky-AI:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces request logging support in the vLLM async engine via enable_log_requests and max_log_len options. While the implementation is secure by default, a medium-severity risk exists where sensitive user data could be logged if the feature is enabled in a production environment. It is recommended to add a strong warning in the code to alert operators to this risk. Additionally, a critical fix for a version check has been incorporated to prevent potential crashes with specific vLLM versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
+generator.engine_init_kwargs.enable_log_requests=trueand+generator.engine_init_kwargs.max_log_len=256for vllm async engine.