[Core] New Create method for processes#13708
Merged
loumalouomega merged 7 commits intoKratosMultiphysics:masterfrom Aug 11, 2025
Merged
[Core] New Create method for processes#13708loumalouomega merged 7 commits intoKratosMultiphysics:masterfrom
Create method for processes#13708loumalouomega merged 7 commits intoKratosMultiphysics:masterfrom
Conversation
* Implementing a `Create` method for several processes. * Some clean up * More clean up * Even more clean up * Minor refactor
loumalouomega
added
Kratos Core
FastPR
matekelemen
reviewed
Aug 9, 2025
Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
| { | ||
| const std::string master_model_part_name = ThisParameters["master_model_part_name"].GetString(); | ||
| const std::string slave_model_part_name = ThisParameters["slave_model_part_name"].GetString(); | ||
| return Kratos::make_unique<ApplyPeriodicConditionProcess>(rModel.GetModelPart(master_model_part_name), rModel.GetModelPart(slave_model_part_name), ThisParameters); |
Member
There was a problem hiding this comment.
Shouldn't' this be a shared_ptr?
Contributor
There was a problem hiding this comment.
wait how does this even compile?
Contributor
There was a problem hiding this comment.
Wow OK this is by design.
Look at overload 13:
https://en.cppreference.com/w/cpp/memory/shared_ptr/shared_ptr.html
I guess unique => shared is a safe conversion, but not the other way around.
matekelemen
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding new
Createmethod for some core processes.🆕 Changelog
Createmethod for processes