[GeoMechanicsApplication] Use standard import mechanism for staged analyses

[markelov208]

📝 Description
A brief description of the PR.

Please mark the PR with appropriate tags:

• replaced "input_type": "mdpa" in all ProjectParameters_stage[2,3,...].json on "input_type": "use_input_model_part"

[rfaasse]

Thanks for picking this up! I think it's almost ready to go, I found some mdpa files that can probably be removed since they're not referenced anymore.

Also: Do you know what the reason is that you had to revert the one in test_nodal_hydraulic_head?

[markelov208]

Thanks for picking this up! I think it's almost ready to go, I found some mdpa files that can probably be removed since they're not referenced anymore.

Also: Do you know what the reason is that you had to revert the one in test_nodal_hydraulic_head?

Hi Richard, many thanks for the review. You are absolutely right and some mdpa files can be removed and removed now. Concerning the 'test_nodal_hydraulic_head', as far as I understand this is a parametrised test and not staged test. Kind regards

[rfaasse]

Thanks for processing the review comments and removing the redundant mdpa files. I think you removed a bit too much from the project param settings though, so if you could revert that part (see also my comment for more clarity), we are ready to merge this 👍

[rfaasse]

Could you revert the removal of the settings in the json? We still need the model_import_settings with the use_import_model_part (like you changed it before), it's just that we don't need the mdpa file itself anymore. This also holds for the other project params where you deleted this.

The tests still pass, that's true, but the reason we want to have use_input_model_part as input type, is to be able to simplify some code in the geomechanicsanalysis later (related to the orchestrator based workflow), so we still need it

[markelov208]

Done. Unfortunately, model_import_settings cannot be empty, so "input_type": "mdpa" is added. mdpa can be omitted.

[rfaasse]

As in the other parameter files, the input_type should be put to use_input_model_part, such that the importer knows not to search for an mdpa file. Sorry if that wasn't clear (see next comment for clarity). The same holds for the other ones.

[rfaasse]

One minor thing left, sorry for the confusion here, I tried to be more clear in this review

[rfaasse]

As in the other parameter files, the input_type should be put to use_input_model_part, such that the importer knows not to search for an mdpa file. Sorry if that wasn't clear (see next comment for clarity). The same holds for the other ones.

[rfaasse]

Perfect, thanks, ready to go!