Update SBM: manage mixed boundary conditions from a NURBS file#13674
Merged
Update SBM: manage mixed boundary conditions from a NURBS file#13674
Conversation
NickNick9
reviewed
Jul 25, 2025
| if (IsPointInsideSkinBoundary(gauss_point, rPointsBin, rSkinModelPart)) {rKnotSpansAvailable[IdMatrix][i-1][j+1] = 1;} | ||
| } | ||
|
|
||
| // Create 25 "fake" gauss_points to check if the majority are inside or outside |
Contributor
There was a problem hiding this comment.
I would leave 5 personally
| const int num_fake_gauss_points = 7; | ||
| int number_of_inside_gaussian_points = 0; | ||
| for (IndexType i_GPx = 0; i_GPx < num_fake_gauss_points; i_GPx++){ | ||
| double x_coord = j*rKnotStepUV[0] + rKnotStepUV[0]/(num_fake_gauss_points+1)*(i_GPx+1) + rStartingPosition[0]; |
Contributor
There was a problem hiding this comment.
were we sure about this "+1"?
| } | ||
|
|
||
| // Mark the knot span as available or not depending on the number of Gauss Points Inside/Outside | ||
| if (number_of_inside_gaussian_points < Lambda*num_fake_gauss_points*num_fake_gauss_points) { |
Contributor
There was a problem hiding this comment.
this is weird no? the total number of fake gauss points is 49 or 64?
NickNick9
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Modification to the IgaModelerSbm. Create one submodelpart for each boundary layer.
Associate BC to each surrogate quadrature point by the layer of the projection on the skin/true boundary.
🆕 Changelog