[GeoMechanicsApplication] Remove two unused piping interface elements#13628
Merged
[GeoMechanicsApplication] Remove two unused piping interface elements#13628
Conversation
github-project-automation
bot
moved this to In progress
in GeoMechanicsApplication (Deltares)
rfaasse
approved these changes
Jul 14, 2025
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Thanks for this clean-up! I don't see any issues here, I just want to check if these old interface-based piping elements (3D6N and 3D8N) are also not used by anyone else (I can't imagine, because it seems they were indeed unusable due to certain functionality not being implemented, but just double-checking).
Comment on lines
-126
to
-140
| template <> | ||
| void SteadyStatePwPipingElement<3, 6>::CalculateLength(const GeometryType& Geom) | ||
| { | ||
| KRATOS_ERROR << " Length of SteadyStatePwPipingElement3D6N element is not " | ||
| "implemented" | ||
| << std::endl; | ||
| } | ||
|
|
||
| template <> | ||
| void SteadyStatePwPipingElement<3, 8>::CalculateLength(const GeometryType& Geom) | ||
| { | ||
| KRATOS_ERROR << " Length of SteadyStatePwPipingElement3D8N element is not " | ||
| "implemented" | ||
| << std::endl; | ||
| } |
Contributor
There was a problem hiding this comment.
Are these always called in a piping calculation? Or is it similar to e.g our interface geometry, where we might say: length is not implemented for a surface interface?
Comment on lines
-265
to
-283
| template <> | ||
| double SteadyStatePwPipingElement<3, 6>::CalculateHeadGradient(const PropertiesType& Prop, | ||
| const GeometryType& Geom, | ||
| double dx) | ||
| { | ||
| KRATOS_ERROR << " head gradient calculation of " | ||
| "SteadyStatePwPipingElement3D6N element is not implemented" | ||
| << std::endl; | ||
| } | ||
|
|
||
| template <> | ||
| double SteadyStatePwPipingElement<3, 8>::CalculateHeadGradient(const PropertiesType& Prop, | ||
| const GeometryType& Geom, | ||
| double dx) | ||
| { | ||
| KRATOS_ERROR << " head gradient calculation of " | ||
| "SteadyStatePwPipingElement3D8N element is not implemented" | ||
| << std::endl; | ||
| } |
Contributor
There was a problem hiding this comment.
Also here, is this function always called in a piping calculation?
github-project-automation
bot
moved this from In progress
to Reviewer approved
in GeoMechanicsApplication (Deltares)
github-project-automation
bot
moved this from Reviewer approved
to Done
in GeoMechanicsApplication (Deltares)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Removed elements "SteadyStatePwPipingElement3D6N" and "SteadyStatePwPipingElement3D8N", since they were unused. In fact, they couldn't be used, since two parts of their implementation (
CalculateLengthandCalculateHeadGradient) would unconditionally raise an error.