[GeoMechanicsApplication] Extend class GeoIncrementalLinearElasticInterfaceLaw to include planar interface behavior

[markelov208]

📝 Description
A brief description of the PR.

Please mark the PR with appropriate tags:

• modified input for CalculateElasticMatrix in ConstitutiveLawDimension
• added interface_plane_strain and interface_three_dimensional_surface for 2D and 3D cases, respectively
• removed underscore in Geo_IncrementalLinearElasticInterfaceLaw
• registered GeoIncrementalLinearElasticInterface3DSurfaceLaw for future
• added 11 unit tests
• updated documentation for Incremental linear elastic interface law

[WPK4FEM]

Hi Gennady,
When you and Anne dragged me into talking about this PR, I had started reading. I hardly have anything to add to the discussion we already had. The implementation and testing of it are clear to me.
Wijtze Pieter

[WPK4FEM]

Could we modify MakeInterfaceConstitutiveMatrix such that it fills the (2, 2) position correctly or is it more natural to have a local implementation of it?

[markelov208]

I don't have a solid view right now. Perhaps, Anne and Richard will tell their opinion. Initially, MakeGeneralInterfaceConstitutiveMatrix was created but after our conversation I removed it because many such methods may follow.

[avdg81]

I agree with @WPK4FEM, and I think we can do it as follows. First, we need to add a function parameter of type std::size_t to ConstitutiveLawUtilities::MakeInterfaceConstitutiveMatrix, which represents the number of normal components. Subsequently, when we call this function from either InterfaceThreeDimensionalSurface::CalculateElasticMatrix or InterfacePlaneStrain::CalculateElasticMatrix, we can use the return value of member GetNumberOfNormalComponents to supply the value for this new argument. And then we can remove the assignment here at line 27 (i.e. delete result(2, 2) = result(1, 1);).

The implementation of ConstitutiveLawUtilities::MakeInterfaceConstitutiveMatrix needs to be modified as well. For instance:

Matrix ConstitutiveLawUtilities::MakeInterfaceConstitutiveMatrix(double      NormalStiffness,
                                                                 double      ShearStiffness,
                                                                 std::size_t TractionSize,
                                                                 std::size_t NumberOfNormalComponents)
{
    auto result = Matrix{ZeroMatrix{TractionSize, TractionSize}};
    for (auto i = std::size_t{0}; i < NumberOfNormalComponents; ++i) result(i, i) = NormalStiffness;
    for (auto i = NumberOfNormalComponents; i < TractionSize; ++i) result(i, i) = ShearStiffness;
    return result;
}

[markelov208]

used this version. Now I see why there is GetNumberOfNormalComponents function

[WPK4FEM]

We (Gennady, Anne, Wijtze Pieter, Richard) discussed to drop the _ from here and also from line 367. That implies that some tests should be changed accordingly.

[markelov208]

The underscore is removed

[avdg81]

Hi Gennady,

Thank you very much for creating this clear and well-tested extension of the incremental linear elastic law for interface elements. I have several suggestions, but none of them is blocking. Hope this helps.

One more thing: can you please add an issue on the backlog about updating the dike model with a sheet pile wall, to account for the renaming of the incremental linear elastic law for interfaces? Thanks.

[avdg81]

Since Properties are passed by reference-to-const, I would prefer to use a forward declaration in the header (i.e. here), and move this #include to the implementation files. In this way, when includes/properties.h is changed, we (hopefully) have to recompile fewer files.

[markelov208]

done

[avdg81]

I agree with @WPK4FEM, and I think we can do it as follows. First, we need to add a function parameter of type std::size_t to ConstitutiveLawUtilities::MakeInterfaceConstitutiveMatrix, which represents the number of normal components. Subsequently, when we call this function from either InterfaceThreeDimensionalSurface::CalculateElasticMatrix or InterfacePlaneStrain::CalculateElasticMatrix, we can use the return value of member GetNumberOfNormalComponents to supply the value for this new argument. And then we can remove the assignment here at line 27 (i.e. delete result(2, 2) = result(1, 1);).

The implementation of ConstitutiveLawUtilities::MakeInterfaceConstitutiveMatrix needs to be modified as well. For instance:

Matrix ConstitutiveLawUtilities::MakeInterfaceConstitutiveMatrix(double      NormalStiffness,
                                                                 double      ShearStiffness,
                                                                 std::size_t TractionSize,
                                                                 std::size_t NumberOfNormalComponents)
{
    auto result = Matrix{ZeroMatrix{TractionSize, TractionSize}};
    for (auto i = std::size_t{0}; i < NumberOfNormalComponents; ++i) result(i, i) = NormalStiffness;
    for (auto i = NumberOfNormalComponents; i < TractionSize; ++i) result(i, i) = ShearStiffness;
    return result;
}

[avdg81]

Hi Gennady,

Thanks a lot for processing the review suggestions. It looks really good to me. I have two more very minor suggestions. So I think we're almost ready to merge this work.

[avdg81]

Perhaps we can add "Expected" to the function parameter names to make clearer what it means:

Suggested change

	const Vector& rInitialRelativeDisplacement,
	const Vector& rInitialTraction)
	const Vector& rExpectedInitialRelativeDisplacement,
	const Vector& rExpectedInitialTraction)

[markelov208]

changed

[avdg81]

I really like these checks. But since they are verified at compile time, I'd suggest to move them to the implementation file of the incremental linear elastic constitutive law for interfaces. See for an example the lines near the bottom of file applications/GeoMechanicsApplication/custom_constitutive/small_strain_udsm_2D_interface_law.cpp.

[markelov208]

Thank you for pointing. Done

[avdg81]

This PR looks ready to go. Thanks for all the work Gennady.