[GeomechanicsApplication] added process to calculate total motion#13585
Merged
aronnoordam merged 11 commits intomasterfrom Jul 7, 2025
Merged
[GeomechanicsApplication] added process to calculate total motion#13585aronnoordam merged 11 commits intomasterfrom
aronnoordam merged 11 commits intomasterfrom
Conversation
aronnoordam
changed the title
5 tasks
rfaasse
reviewed
Jul 4, 2025
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Clear and well-tested PR! I only have some suggestions for simplification.
applications/GeoMechanicsApplication/custom_processes/calculate_total_motion_process.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_processes/calculate_total_motion_process.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_processes/calculate_total_motion_process.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
-98
to
-111
| void AccumulateTotalDisplacementField() override | ||
| { | ||
| for (auto& node : mrModelPart.Nodes()) { | ||
| node.GetSolutionStepValue(TOTAL_DISPLACEMENT) += node.GetSolutionStepValue(INCREMENTAL_DISPLACEMENT); | ||
| } | ||
| } | ||
|
|
||
| void ComputeIncrementalDisplacementField() override | ||
| { | ||
| for (auto& node : mrModelPart.Nodes()) { | ||
| node.GetSolutionStepValue(INCREMENTAL_DISPLACEMENT) = | ||
| node.GetSolutionStepValue(DISPLACEMENT, 0) - node.GetSolutionStepValue(DISPLACEMENT, 1); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I think it'd be a good idea to keep these functions and use the processes here. Then we also don't need to expose the ModelPart&. That also simplifies this PR quite a bit, because we don't need part of the changes.
rfaasse
approved these changes
Jul 4, 2025
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Thanks for processing the review comments, this is good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added process to calculate TOTAL motion, where motion is either DISPLACEMENT or ROTATION
also fixed a unrelated test which suddenly failed for some reason