[Core] Adding benchmarks for unordered_set and unordered_map#13570
Merged
loumalouomega merged 3 commits intomasterfrom Jul 1, 2025
Merged
[Core] Adding benchmarks for unordered_set and unordered_map#13570loumalouomega merged 3 commits intomasterfrom
unordered_set and unordered_map#13570loumalouomega merged 3 commits intomasterfrom
Conversation
loumalouomega
added
Kratos Core
Benchmarking
FastPR
matekelemen
reviewed
Jun 30, 2025
Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
Member
Author
|
Done |
matekelemen
approved these changes
Jul 1, 2025
| } | ||
| for (auto _ : state) { | ||
| for (const auto& val : data) { | ||
| benchmark::DoNotOptimize(umap.find(val)); |
Contributor
There was a problem hiding this comment.
I wonder if this will really not be optimized out. I imagine this function allocates no memory, and the result is discarded immediately.
Anyway, we'll only find out when we actually run these benchmarks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding benchmarks for
unordered_setandunordered_map, ported from #12861, as transition PR, as it looks like that we may finally use a different library.🆕 Changelog
unordered_setandunordered_map